Skip to content

Fix broken Element Call in 25.05.0 #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 7, 2025

Content

Ensure that the Rust room is not closed while the driver needs it.
I tried to make a wider rework by just using a Room (from Rust), but it does not work since we need an active timeline.

Motivation and context

Fix regression introduced in #4678 and so closes #4689

Screenshots / GIFs

Tests

  • Start a call
  • The call starts

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner May 7, 2025 23:52
@bmarty bmarty requested review from ganfra and removed request for a team May 7, 2025 23:52
@bmarty bmarty added Z-NextRelease For issues and PRs which should be included in the NextRelease. PR-Bugfix For bug fix labels May 7, 2025
@bmarty bmarty requested review from jmartinesp and removed request for ganfra May 7, 2025 23:52
@@ -48,7 +48,6 @@ class DefaultCallWidgetProvider @Inject constructor(
).getOrThrow()

val driver = room.getWidgetDriver(widgetSettings).getOrThrow()
room.destroy()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot destroy the room here since it will close the FFI Room and the WidgetDriver needs it to work properly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry for the regression 😞 .

Copy link
Contributor

github-actions bot commented May 7, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tLo88G

Copy link

sonarqubecloud bot commented May 7, 2025

Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.11%. Comparing base (5fb0fc0) to head (6587632).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...d/libraries/matrix/impl/widget/RustWidgetDriver.kt 0.00% 2 Missing ⚠️
...droid/libraries/matrix/impl/room/JoinedRustRoom.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4694      +/-   ##
===========================================
- Coverage    80.11%   80.11%   -0.01%     
===========================================
  Files         2127     2127              
  Lines        56292    56294       +2     
  Branches      7018     7018              
===========================================
- Hits         45101    45100       -1     
- Misses        8779     8782       +3     
  Partials      2412     2412              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -48,7 +48,6 @@ class DefaultCallWidgetProvider @Inject constructor(
).getOrThrow()

val driver = room.getWidgetDriver(widgetSettings).getOrThrow()
room.destroy()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry for the regression 😞 .

@jmartinesp jmartinesp merged commit 0beec20 into develop May 8, 2025
39 of 40 checks passed
@jmartinesp jmartinesp deleted the feature/feature/bma/fixElementCallCrash branch May 8, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 25.5.0 broke element-call
2 participants