-
Notifications
You must be signed in to change notification settings - Fork 226
Fix broken Element Call in 25.05.0 #4694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -48,7 +48,6 @@ class DefaultCallWidgetProvider @Inject constructor( | |||
).getOrThrow() | |||
|
|||
val driver = room.getWidgetDriver(widgetSettings).getOrThrow() | |||
room.destroy() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot destroy the room here since it will close the FFI Room and the WidgetDriver needs it to work properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and sorry for the regression 😞 .
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4694 +/- ##
===========================================
- Coverage 80.11% 80.11% -0.01%
===========================================
Files 2127 2127
Lines 56292 56294 +2
Branches 7018 7018
===========================================
- Hits 45101 45100 -1
- Misses 8779 8782 +3
Partials 2412 2412 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -48,7 +48,6 @@ class DefaultCallWidgetProvider @Inject constructor( | |||
).getOrThrow() | |||
|
|||
val driver = room.getWidgetDriver(widgetSettings).getOrThrow() | |||
room.destroy() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and sorry for the regression 😞 .
Content
Ensure that the Rust room is not closed while the driver needs it.
I tried to make a wider rework by just using a Room (from Rust), but it does not work since we need an active timeline.
Motivation and context
Fix regression introduced in #4678 and so closes #4689
Screenshots / GIFs
Tests
Tested devices
Checklist