Feature : Report room

[ganfra]

Content

This PR allows to report an invite and a room, through different entry points.
For now the feature is disabled, if you want to test you need to override the MatrixConfiguration.CAN_REPORT_ROOM.
In the future we'll be using this PR in the sdk to check if the api is supported, so we use different flows.

Motivation and context

Closes #4315
Closes #4438

Screenshots / GIFs

Tests

• Make sure MatrixConfiguration.CAN_REPORT_ROOM is enabled or not, depending on your tests

For report room :

• Long click on RoomList item to see context menu with report room entry
• Click on report
• See the new screen.

For report invite :

• Click on decline button from RoomList item
• See the new bottomsheet => click on decline and block
• See the new screen

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[ElementBot]

	Warnings
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L5 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L25 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L203 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L232 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L364 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L5 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L25 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L203 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L232 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L364 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

Generated by 🚫 dangerJS against 6ca22ef

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/3VKJ2t

[codecov]

Codecov Report

Attention: Patch coverage is 89.61268% with 59 lines in your changes missing coverage. Please review.

Project coverage is 80.11%. Comparing base (baa9f01) to head (6ca22ef).
Report is 5 commits behind head on develop.

Files with missing lines	Patch %	Lines
...vite/impl/acceptdecline/AcceptDeclineInviteView.kt	56.25%	5 Missing and 2 partials ⚠️
...ment/android/features/invite/impl/DeclineInvite.kt	83.87%	1 Missing and 4 partials ⚠️
...ent/android/features/roomlist/impl/RoomListView.kt	37.50%	4 Missing and 1 partial ⚠️
...android/libraries/matrix/impl/room/RustBaseRoom.kt	0.00%	5 Missing ⚠️
.../element/android/features/invite/api/InviteData.kt	71.42%	2 Missing and 2 partials ⚠️
...ent/android/features/reportroom/impl/ReportRoom.kt	78.94%	2 Missing and 2 partials ⚠️
...android/features/reportroom/impl/ReportRoomView.kt	93.44%	1 Missing and 3 partials ⚠️
...eclineandblock/DefaultDeclineAndBlockEntryPoint.kt	0.00%	3 Missing ⚠️
...id/features/reportroom/impl/ReportRoomPresenter.kt	90.00%	2 Missing and 1 partial ⚠️
...eatures/roomlist/impl/RoomListDeclineInviteMenu.kt	94.00%	0 Missing and 3 partials ⚠️
... and 12 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4654      +/-   ##
===========================================
+ Coverage    80.01%   80.11%   +0.10%     
===========================================
  Files         2107     2123      +16     
  Lines        55838    56235     +397     
  Branches      6972     7007      +35     
===========================================
+ Hits         44678    45052     +374     
- Misses        8765     8774       +9     
- Partials      2395     2409      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bmarty]

LGTM, just a few remarks but nothing blocking I think.

[bmarty]

If I am reading this properly, if there is an error here, the room will not be reported, and the user will not be able to do it again since the room has been left successfully. Is it OK?

We should maybe try to report the room, and return the error after?

[bmarty]

I keep this one for later.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud