Skip to content

Render caller avatar on Incoming call screen #4635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 24, 2025

Content

Ensure that the image loader is set, else the IncomingCallActivity will not be able to render the avatar.

Note that this is a temporary fix, we may want to revisit how we handle the Coil image loader singleton.

This PR also ensure that a background color is set else we can end up with light text on light background.

Motivation and context

Fixes #4633
Fixes #4629

Screenshots / GIFs

Before After
IncomingCall-Before2 IncomingCall-After

Tests

  • Set the system color to light
  • Set the app theme to dark
  • Kill the app
  • Lock the device (screen is off)
  • Receive a call from a DM where other user has an avatar
  • Observe that the screen now renders the caller avatar and is rendering light text on dark background. Previously it was only rendering initials avatar, with light text on light background.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-Bugfix For bug fix label Apr 24, 2025
@bmarty bmarty requested a review from a team as a code owner April 24, 2025 12:46
@bmarty bmarty requested review from ganfra and removed request for a team April 24, 2025 12:46
Copy link
Contributor

github-actions bot commented Apr 24, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ynKe6L

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.99%. Comparing base (76e1612) to head (3e0cf90).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4635   +/-   ##
========================================
  Coverage    79.99%   79.99%           
========================================
  Files         2107     2107           
  Lines        55811    55818    +7     
  Branches      6954     6955    +1     
========================================
+ Hits         44644    44651    +7     
  Misses        8772     8772           
  Partials      2395     2395           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 24, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 24, 2025
@bmarty bmarty enabled auto-merge (squash) April 24, 2025 21:07
Copy link

@bmarty bmarty merged commit add03ab into develop Apr 24, 2025
29 checks passed
@bmarty bmarty deleted the feature/bma/fixCallTheme branch April 24, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incoming Call screen does not render the caller avatar EC 1:1 incoming call: still displayed in light color under certain conditions.
2 participants