Accessibility: improve behavior of list items

[bmarty]

Content

Improve accessibility for ListItem.

One example, when long press on a room and select the "Favorite" item, so in this screen:

The current read text is:

Favorite favorite double tap to activate

so quite wrong and do not give the state of the switch. With this changes, if the switch is on, the read text is:

on favorite switch, double tap to toggle

and if the switch if off, the read text is:

off favorite switch, double tap to toggle

and the switch itself is not focusable, so the next focusable item is the "Settings" item.

Remove callback duplication, that can lead to screen reader focused on the switch itself, which has no added value if the behavior is the same.

Motivation and context

Improve accessibility.

Replacement for #4047

Screenshots / GIFs

Tests

• Enable screen reader and check the behavior of the List items used in bottom sheet, settings...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/jb2fJ9

[bmarty]

Waiting for a design decision about this change:

(asked in https://www.figma.com/design/7TqjqdMBaPpm3IavKsMYu6?node-id=5235-51684&m=dev#1228513902)

[bmarty]

This is breaking click on ListItem, needs to push a fix.

[codecov]

Codecov Report

Attention: Patch coverage is 89.65517% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.01%. Comparing base (4e0d00d) to head (a65d6f7).
Report is 13 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ndroid/features/poll/impl/create/CreatePollView.kt	25.00%	3 Missing ⚠️
...ibraries/designsystem/theme/components/ListItem.kt	91.42%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4626   +/-   ##
========================================
  Coverage    80.01%   80.01%           
========================================
  Files         2103     2103           
  Lines        55786    55815   +29     
  Branches      6939     6957   +18     
========================================
+ Hits         44638    44663   +25     
- Misses        8755     8757    +2     
- Partials      2393     2395    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ganfra]

I think it would be better to let the Presenter handle this, but as it's not new, feel free to ignore.