Skip to content

[a11y] Make more items focusable #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2025
Merged

[a11y] Make more items focusable #4605

merged 4 commits into from
Apr 22, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 17, 2025

Content

  • First commit: Ensure that the settings can be open when the screen reader is active and the account has no avatar.
  • Second commit: Ktx cleanup (unrelated to a11y, but fixes IDE warning, and improve the code, do not want to create a dedicated PR just for that)
  • Third commit: ensure that the screen reader can focus on the user avatar in the edit profile view.

Motivation and context

Closes #4599 and improve a11y of the application.

Screenshots / GIFs

Tests

  • Enable screen reader
  • on an account with no avatar, ensure that the user can open the settings
  • ensure that the user can update the account avatar

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-Bugfix For bug fix label Apr 17, 2025
@bmarty bmarty requested a review from a team as a code owner April 17, 2025 12:41
@bmarty bmarty requested review from jmartinesp and removed request for a team April 17, 2025 12:41
Copy link
Contributor

github-actions bot commented Apr 17, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/EXzjsY

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.01%. Comparing base (47c7a74) to head (de11e83).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...droid/libraries/androidutils/system/SystemUtils.kt 0.00% 2 Missing ⚠️
...d/features/call/impl/utils/CallIntentDataParser.kt 50.00% 0 Missing and 1 partial ⚠️
...o/element/android/features/login/impl/util/Util.kt 0.00% 1 Missing ⚠️
...impl/web/WebClientUrlForAuthenticationRetriever.kt 0.00% 1 Missing ⚠️
.../libraries/androidutils/browser/ChromeCustomTab.kt 0.00% 1 Missing ⚠️
...es/matrix/impl/permalink/DefaultPermalinkParser.kt 0.00% 1 Missing ⚠️
.../libraries/oidc/impl/customtab/CustomTabHandler.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4605   +/-   ##
========================================
  Coverage    80.00%   80.01%           
========================================
  Files         2103     2103           
  Lines        55749    55758    +9     
  Branches      6940     6941    +1     
========================================
+ Hits         44603    44612    +9     
  Misses        8752     8752           
  Partials      2394     2394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty merged commit bacfa09 into develop Apr 22, 2025
30 of 31 checks passed
@bmarty bmarty deleted the feature/bma/a11ySettings branch April 22, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

settings button not focusable with the accessibility API when account has no profile picture
2 participants