Skip to content

Fetch the initial ignored user list manually when subscribing #4598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

jmartinesp
Copy link
Member

Content

The SDK won't return it automatically, so we need to fetch it manually.

Motivation and context

Fixes #4597

Tests

  • You should see the ignored user list as soon as you open the settings screen if you had any ignored users.
  • If you comment out the changes and restart the app, it'll be missing until you ignore/unignore someone.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

The SDK won't return it automatically, so we need to fetch it manually.
@jmartinesp jmartinesp added the PR-Bugfix For bug fix label Apr 16, 2025
@jmartinesp jmartinesp requested a review from a team as a code owner April 16, 2025 08:35
@jmartinesp jmartinesp requested review from ganfra and removed request for a team April 16, 2025 08:35
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/wNj1FA

Copy link

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.01%. Comparing base (f74486f) to head (6a64250).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4598      +/-   ##
===========================================
- Coverage    80.01%   80.01%   -0.01%     
===========================================
  Files         2103     2103              
  Lines        55646    55647       +1     
  Branches      6930     6930              
===========================================
  Hits         44527    44527              
- Misses        8723     8724       +1     
  Partials      2396     2396              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp jmartinesp changed the title Fetch the initial ignored user list manually Fetch the initial ignored user list manually when subscribing Apr 16, 2025
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast fix!

@jmartinesp jmartinesp merged commit a11ca17 into develop Apr 16, 2025
39 checks passed
@jmartinesp jmartinesp deleted the fix/pull-ignored-user-list-when-subscribing branch April 16, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocked users settings menu entry disappears
2 participants