-
Notifications
You must be signed in to change notification settings - Fork 226
Introduce PushHistoryService to store data about the received push #4573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4573 +/- ##
===========================================
+ Coverage 80.08% 80.10% +0.01%
===========================================
Files 2087 2098 +11
Lines 55121 55442 +321
Branches 6876 6896 +20
===========================================
+ Hits 44144 44411 +267
- Misses 8617 8659 +42
- Partials 2360 2372 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Was: w: /libraries/troubleshoot/impl/src/test/kotlin/io/element/android/libraries/troubleshoot/impl/history/PushHistoryPresenterTest.kt:35:27 Cannot access class 'PushProvider' in the expression type. While it may work, this case indicates a configuration mistake and can lead to avoidable compilation errors, so it may be forbidden soon. Check your module classpath for missing or conflicting dependencies.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, LGTM!
Does this help in removing push notifications once you looked at the message in another client? |
Nope |
This feature is very helpful. I think it would help to be able to see the received data (JSON), especially when the push is "invalid push data". What do you think ? I see number of them with UnifiedPush |
Actually this is a bit misleading. Data are not invalid, it's just that this is a push with no EventId and no RoomId. I think these are push that are sent to update the I'll update the wording a bit so that it's clearer. |
I see. I have observed this kind of error when receiving a message when I also had the web client opened. I only received the push notification with the error. Having the JSON would have help to be sure it was this kind of notification (then there might be something to look at server side) |
It looks good, I think it will be helpful |
(updated and in review at #4601) |
Content
Introduce PushHistoryService to store data about the received push
Add a push database to store the info about the push.
Motivation and context
Help diagnostic notification issues.
Screenshots / GIFs
Screen_recording_20250411_112024.mp4
Tests
Tested devices
Checklist