Skip to content

Fix the share location URI #4544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Fix the share location URI #4544

merged 2 commits into from
Apr 7, 2025

Conversation

jmartinesp
Copy link
Member

Content

Use ENGLISH locale to make sure the coordinates are formatted using the right decimal separator.

Also, when no label parameter was added, the URI just centered the map on some coordinates, instead of adding a marker. That's also fixed now by using an empty label.

Motivation and context

Fixes #4541

Screenshots / GIFs

Screen.Recording.2025-04-07.at.09.15.11.mov

Tests

With the app's language in Brazilian Portuguese:

  • Share your location, or open an already existing shared location.
  • Tap on the share icon in the location viewer.

The location should be shared correctly with some other app, displaying the marker instead of a search or just a centered map.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 16

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

Use `ENGLISH` locale to make sure the coordinates are formatted using the right decimal separator.

Also, when no label parameter was added, the URI just centered the map on some coordinates, instead of adding a marker
@jmartinesp jmartinesp added the PR-Bugfix For bug fix label Apr 7, 2025
@jmartinesp jmartinesp requested a review from a team as a code owner April 7, 2025 07:19
@jmartinesp jmartinesp requested review from ganfra and removed request for a team April 7, 2025 07:19
Copy link
Contributor

github-actions bot commented Apr 7, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/2pjGem

Copy link

sonarqubecloud bot commented Apr 7, 2025

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.14%. Comparing base (e557ee2) to head (6feb65e).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
...tion/impl/common/actions/AndroidLocationActions.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4544      +/-   ##
===========================================
- Coverage    80.14%   80.14%   -0.01%     
===========================================
  Files         2083     2083              
  Lines        54902    54900       -2     
  Branches      6848     6848              
===========================================
- Hits         43999    43997       -2     
  Misses        8543     8543              
  Partials      2360     2360              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp jmartinesp merged commit f335eb1 into develop Apr 7, 2025
35 of 36 checks passed
@jmartinesp jmartinesp deleted the fix/share-location-uri branch April 7, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To share location with google maps is broken in brazilian portuguese
2 participants