Skip to content

Add a inderminate progress bar when loging out and in Waiting state. #4538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 4, 2025

Content

When logging out and the key back up state is Waiting, a new progress bar is displayed. After 2s a Text is displayed to, to ask the user to check their internet connection.

Note that if they are network error, we should be in the state BackupUploadState.SteadyException, so there is maybe an issue SDK side.

Motivation and context

Close internal issue.

Screenshots / GIFs

See recorded one

Tests

  • Login to an account
  • send/receive a few message to e2e room
  • switch to airplane mode
  • try to logout
  • with a bit of luck you'll have unsaved keys and the new screen will be rendered.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner April 4, 2025 15:17
@bmarty bmarty requested review from ganfra and removed request for a team April 4, 2025 15:17
@bmarty bmarty added the PR-Bugfix For bug fix label Apr 4, 2025
Copy link
Contributor

github-actions bot commented Apr 4, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link:

Copy link

sonarqubecloud bot commented Apr 4, 2025

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.15%. Comparing base (e557ee2) to head (0833766).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4538   +/-   ##
========================================
  Coverage    80.14%   80.15%           
========================================
  Files         2083     2083           
  Lines        54902    54927   +25     
  Branches      6848     6850    +2     
========================================
+ Hits         43999    44024   +25     
  Misses        8543     8543           
  Partials      2360     2360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit b7abdb0 into develop Apr 7, 2025
36 checks passed
@bmarty bmarty deleted the feature/bma/logoutLoading branch April 7, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants