Remember flows

[bmarty]

Content

Ensure that Flows are not created again when a recomposition occurred. They should be remembered, except if they are hold in a val. So this PR:

• add a Konsist test to detect potential issue with this
• add remember around flow function creator
• change fun which return flow to val, so that it's clear the the flow is not created at each usage.

Motivation and context

Tiny performance improvement and Compose best practice.

Screenshots / GIFs

No expected change

Tests

• No expected change

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/1hjLzj

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

Attention: Patch coverage is 95.03546% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.16%. Comparing base (c09ff58) to head (ae0ee55).
Report is 3 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../biometric/DefaultBiometricAuthenticatorManager.kt	0.00%	3 Missing ⚠️
...roid/libraries/matrix/impl/sync/RustSyncService.kt	0.00%	1 Missing ⚠️
...oid/libraries/matrix/impl/timeline/RustTimeline.kt	83.33%	1 Missing ⚠️
...x/impl/widget/DefaultCallWidgetSettingsProvider.kt	0.00%	1 Missing ⚠️
...roid/libraries/matrix/test/sync/FakeSyncService.kt	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4533      +/-   ##
===========================================
+ Coverage    80.14%   80.16%   +0.01%     
===========================================
  Files         2083     2082       -1     
  Lines        54902    54931      +29     
  Branches      6848     6847       -1     
===========================================
+ Hits         43999    44033      +34     
+ Misses        8543     8539       -4     
+ Partials      2360     2359       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jmartinesp]

LGTM, thanks!

[jmartinesp]

Maybe using an annotation to suppress the warning would be better, but I don't know if that's possible/easy. Just something we could keep in mind for future usages of Konsist.

[jmartinesp]

TIL about our mapState helper function 👀 .