Remove alias from room invite item #4531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4531 +/- ##
========================================
Coverage 80.14% 80.14%
========================================
Files 2083 2083
Lines 54902 54902
Branches 6849 6848 -1
========================================
Hits 43999 43999
Misses 8543 8543
Partials 2360 2360 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmartinesp
approved these changes
Apr 3, 2025
jmartinesp
reviewed
Apr 3, 2025
| @@ -232,13 +231,12 @@ private fun NameAndTimestampRow( | |||
| private fun InviteSubtitle( | |||
| isDm: Boolean, | |||
| inviteSender: InviteSender?, | |||
| canonicalAlias: RoomAlias?, | |||
| modifier: Modifier = Modifier | |||
| ) { | |||
| val subtitle = if (isDm) { | |||
| inviteSender?.userId?.value | |||
There was a problem hiding this comment.
Could be inviteSender?.userId?.value?.takeIf { isDm }, maybe.
There was a problem hiding this comment.
Yes, I was expecting this remark :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Remove alias from room invite item
Motivation and context
Cleaner ui. Room alias is still visible in the invitation detail screen (when user clicks on the invitation itself, not the buttons to accept or reject)
Screenshots / GIFs
See recorded one
Tests
Tested devices
Checklist