Skip to content

Replace OutlinedTextField by our TextField #4521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 2, 2025
Merged

Replace OutlinedTextField by our TextField #4521

merged 11 commits into from
Apr 2, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 2, 2025

Content

Replace OutlinedTextField by our TextField

Motivation and context

Compound rules.
Follow up for #4512

Screenshots / GIFs

See recorded once

Tests

  • Checking the recorded screenshot should be enough.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-Misc For other changes label Apr 2, 2025
@bmarty bmarty requested a review from a team as a code owner April 2, 2025 09:36
@bmarty bmarty requested review from ganfra and removed request for a team April 2, 2025 09:36
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 2, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/sZYAud

@codecov Codecov
Copy link

codecov bot commented Apr 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.18%. Comparing base (1fdb590) to head (71e4c40).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
.../designsystem/components/list/TextFieldListItem.kt 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4521      +/-   ##
===========================================
+ Coverage    80.11%   80.18%   +0.07%     
===========================================
  Files         2081     2081              
  Lines        55760    55736      -24     
  Branches      6829     6827       -2     
===========================================
+ Hits         44673    44694      +21     
+ Misses        8744     8696      -48     
- Partials      2343     2346       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 2, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 2, 2025
@bmarty bmarty requested review from jmartinesp and removed request for ganfra April 2, 2025 11:52
jmartinesp
jmartinesp reviewed Apr 2, 2025
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, but I'd like to discuss the content padding values a bit.

.../snapshots/images/libraries.designsystem.components.dialogs_ListDialogContent_Dialogs_en.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change applyPaddingToContent to be true by default? I think it's more likely we want it enabled for most of our custom layouts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree, I believe the padding was reduced for the previous EditText (without box decoration)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I can just remove this parameter applyPaddingToContent ?

...c/test/snapshots/images/libraries.textcomposer_TextComposerLinkDialogCreateLink_Day_0_en.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should probably have some extra content padding for the text fields.

...src/test/snapshots/images/libraries.textcomposer_TextComposerLinkDialogEditLink_Day_0_en.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this other one.

tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistImportTest.kt
@@ -24,4 +24,17 @@ class KonsistImportTest {
it.name == "org.jetbrains.annotations.VisibleForTesting"
}
}

@Test
fun `OutlinedTextField should not be used`() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 2, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 2, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jmartinesp
jmartinesp approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@bmarty bmarty enabled auto-merge (squash) April 2, 2025 13:53
@bmarty bmarty merged commit 670af86 into develop Apr 2, 2025
26 of 27 checks passed
@bmarty bmarty deleted the feature/bma/textFieldDialog2 branch April 2, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees
No one assigned
Labels
PR-Misc For other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmarty @jmartinesp @ElementBot