Skip to content

Timeline header: ensure that the decoration is clickable #4495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Mar 28, 2025

Content

Timeline header: ensure that the decoration is clickable and properly fix the icon rendering (when the room name is too long).

Motivation and context

Whole clickable room title / nice UI

Screenshots / GIFs

Tests

  • Open a DM with a verified user
  • Observe that the room green decoration is clickable and open the room settings.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner March 28, 2025 11:52
@bmarty bmarty requested review from jmartinesp and removed request for a team March 28, 2025 11:52
@bmarty bmarty added the PR-Bugfix For bug fix label Mar 28, 2025
Copy link
Contributor

github-actions bot commented Mar 28, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/kxcxnp

@bmarty
Copy link
Member Author

bmarty commented Mar 28, 2025

Note sure why there are so many diff in the sc recording. It's probably coming from #4484 being merged.

Edit: I have created a branch to record the screenshots currently on develop to confirm this.

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.10%. Comparing base (b7ff9a5) to head (0277406).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4495      +/-   ##
===========================================
- Coverage    80.10%   80.10%   -0.01%     
===========================================
  Files         2080     2080              
  Lines        55680    55679       -1     
  Branches      6812     6812              
===========================================
- Hits         44605    44604       -1     
  Misses        8737     8737              
  Partials      2338     2338              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty force-pushed the feature/bma/roomTitleClick branch from a3a6b4d to 6fb8424 Compare March 28, 2025 13:52
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Mar 28, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Mar 28, 2025
Copy link

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty merged commit 348f787 into develop Mar 28, 2025
31 checks passed
@bmarty bmarty deleted the feature/bma/roomTitleClick branch March 28, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants