Limit the text length in the 'in reply to' preview

[jmartinesp]

Content

What the title says.

Motivation and context

Otherwise, very long texts with no line breaks can cause a Compose crash.

Fixes #3772

Screenshots / GIFs

There shouldn't be any visual change, unless you have a huge screen that can display in reply to previews of > 512 chars.

Tests

• Generate a very long text, > 20k characters, maybe using a lorem ipsum and make sure there are no line breaks.
• Send the text.
• Try to reply to the message.

If the app doesn't crash, we worked around the Compose bug.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/zzHqED

[bmarty]

Thanks!

[bmarty]

I remember that we already have a similar fix (limiting the size of text to avoid a Compose crash), but I can find it. Maybe I dreamt it?
Else maybe create a const for this 512 (not a big deal)?

[jmartinesp]

I had the same issue, I know it's there, I just don't know where 😅 .

EDIT: found it

element-x-android/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/utils/messagesummary/DefaultMessageSummaryFormatter.kt

Line 40 in 97f3be3

private const val MAX_SAFE_LENGTH = 500

[jmartinesp]

I've tried unifying both in an extension function in a new commit.

[bmarty]

I've tried unifying both in an extension function in a new commit.

That's also why I wanted to find where it was done before. Thanks for the update!

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.08%. Comparing base (6123650) to head (d910ea1).
Report is 4 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ibraries/matrix/ui/messages/reply/InReplyToView.kt	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4491   +/-   ##
========================================
  Coverage    80.08%   80.08%           
========================================
  Files         2077     2077           
  Lines        55588    55588           
  Branches      6802     6802           
========================================
  Hits         44519    44519           
  Misses        8733     8733           
  Partials      2336     2336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud