Skip to content

Fix 'unverified session' flow displayed when creating account #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

jmartinesp
Copy link
Member

Content

When creating an account, wait until the session is verified before marking the authentication flow as completed.

Motivation and context

We had a regression at some point on this that went unnoticed.

Tests

  • Create a new account in some HS (m.org maybe).
  • Once the account is created you can progress into using the app as usual, no session verification flow is displayed.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

When creating an account, wait until the session is verified before marking the authentication flow as completed.
@jmartinesp jmartinesp added the PR-Bugfix For bug fix label Mar 25, 2025
@jmartinesp jmartinesp requested a review from a team as a code owner March 25, 2025 11:18
@jmartinesp jmartinesp requested review from ganfra and removed request for a team March 25, 2025 11:18
Copy link
Contributor

github-actions bot commented Mar 25, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/LTD6mC

Copy link

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.08%. Comparing base (f969dcf) to head (e93919d).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4467   +/-   ##
========================================
  Coverage    80.08%   80.08%           
========================================
  Files         2075     2075           
  Lines        55408    55413    +5     
  Branches      6766     6766           
========================================
+ Hits         44373    44379    +6     
+ Misses        8711     8710    -1     
  Partials      2324     2324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp jmartinesp added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Mar 25, 2025
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmartinesp jmartinesp merged commit 5e64898 into develop Mar 25, 2025
35 checks passed
@jmartinesp jmartinesp deleted the fix/verification-on-account-creation branch March 25, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants