Skip to content

Sync Strings - tweaks to identity change messages #4454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andybalaam
Copy link
Member

Content

Tweak the strings in the identity change messages as per element-hq/element-meta#2792

Motivation and context

The existing strings were confusing, and users did not like clicking "Ok" when they did not understand, so this is changed to "Dismiss".

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@andybalaam andybalaam requested a review from a team as a code owner March 21, 2025 15:03
@andybalaam andybalaam requested review from jmartinesp and removed request for a team March 21, 2025 15:03
Copy link
Contributor

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 21, 2025
@jmartinesp jmartinesp mentioned this pull request Mar 24, 2025
@andybalaam andybalaam force-pushed the andybalaam/tweak-identity-change-messages branch from 7e2a1e6 to 4425b7c Compare March 24, 2025 09:19
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.07%. Comparing base (6ae9e33) to head (5990f5a).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...es/impl/crypto/identity/IdentityChangeStateView.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4454      +/-   ##
===========================================
- Coverage    80.08%   80.07%   -0.01%     
===========================================
  Files         2075     2075              
  Lines        55408    55408              
  Branches      6766     6766              
===========================================
- Hits         44373    44369       -4     
- Misses        8711     8712       +1     
- Partials      2324     2327       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp
Copy link
Member

Ah damn, we need to fix the conflicts first now that the other PR is merged.

@andybalaam
Copy link
Member Author

Ah damn, we need to fix the conflicts first now that the other PR is merged.

No worries, I'll do that tomorrow.

@andybalaam andybalaam force-pushed the andybalaam/tweak-identity-change-messages branch from 4425b7c to 5990f5a Compare March 25, 2025 09:27
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmartinesp jmartinesp merged commit f969dcf into element-hq:develop Mar 25, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants