-
Notifications
You must be signed in to change notification settings - Fork 226
Sync Strings - tweaks to identity change messages #4454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Strings - tweaks to identity change messages #4454
Conversation
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
7e2a1e6
to
4425b7c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4454 +/- ##
===========================================
- Coverage 80.08% 80.07% -0.01%
===========================================
Files 2075 2075
Lines 55408 55408
Branches 6766 6766
===========================================
- Hits 44373 44369 -4
- Misses 8711 8712 +1
- Partials 2324 2327 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ah damn, we need to fix the conflicts first now that the other PR is merged. |
No worries, I'll do that tomorrow. |
4425b7c
to
5990f5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Content
Tweak the strings in the identity change messages as per element-hq/element-meta#2792
Motivation and context
The existing strings were confusing, and users did not like clicking "Ok" when they did not understand, so this is changed to "Dismiss".
Checklist