Skip to content

Let element enterprise be able to configure id for mapTiler. #4446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 21, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Mar 20, 2025

Content

Read properties from BuildTimeConfig regarding mapTile for enterprise build.

Also is appId is not available, disable location sharing and location Event view in fullscreen.

Note that if the appId is not present, the timeline will not be able to render the static location preview. Instead, a placeholder will be rendered, like this:

image

Motivation and context

Element Enterprise.

Screenshots / GIFs

Tests

  • There should have no impact on the location sharing feature / rendering in the timeline on EXA build.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner March 20, 2025 17:16
@bmarty bmarty requested review from ganfra and removed request for a team March 20, 2025 17:16
@bmarty bmarty added PR-Build For changes related to build, tools, CI/CD Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Mar 20, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Mar 20, 2025
Copy link
Contributor

github-actions bot commented Mar 20, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xoPiNL

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.04%. Comparing base (811ba95) to head (bf0ad06).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4446   +/-   ##
========================================
  Coverage    80.03%   80.04%           
========================================
  Files         2072     2074    +2     
  Lines        55380    55394   +14     
  Branches      6761     6764    +3     
========================================
+ Hits         44325    44339   +14     
  Misses        8735     8735           
  Partials      2320     2320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty changed the title Let element enterprise be able to configure id for mapTile. Let element enterprise be able to configure id for mapTiler. Mar 21, 2025
Copy link

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@bmarty bmarty merged commit 2fd1c21 into develop Mar 21, 2025
31 checks passed
@bmarty bmarty deleted the feature/bma/mapTilerConfig branch March 21, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants