-
Notifications
You must be signed in to change notification settings - Fork 226
Let element enterprise be able to configure id for mapTiler. #4446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4446 +/- ##
========================================
Coverage 80.03% 80.04%
========================================
Files 2072 2074 +2
Lines 55380 55394 +14
Branches 6761 6764 +3
========================================
+ Hits 44325 44339 +14
Misses 8735 8735
Partials 2320 2320 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Content
Read properties from BuildTimeConfig regarding mapTile for enterprise build.
Also is appId is not available, disable location sharing and location Event view in fullscreen.
Note that if the appId is not present, the timeline will not be able to render the static location preview. Instead, a placeholder will be rendered, like this:
Motivation and context
Element Enterprise.
Screenshots / GIFs
Tests
Tested devices
Checklist