Skip to content

Compose : add immutability to some Reaction classes #3224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Jul 19, 2024

Content

Some classes related to Reaction weren't Immutable and so the composable functions weren't skippable.

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added the PR-Misc For other changes label Jul 19, 2024
@ganfra ganfra marked this pull request as ready for review July 19, 2024 15:15
@ganfra ganfra requested a review from a team as a code owner July 19, 2024 15:15
@ganfra ganfra requested review from jmartinesp and removed request for a team July 19, 2024 15:15
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/GiD4L9

Copy link

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.13%. Comparing base (21553d7) to head (2f0e9eb).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3224      +/-   ##
===========================================
- Coverage    76.13%   76.13%   -0.01%     
===========================================
  Files         1645     1645              
  Lines        38816    38819       +3     
  Branches      7520     7523       +3     
===========================================
- Hits         29554    29553       -1     
+ Misses        5361     5360       -1     
- Partials      3901     3906       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ganfra ganfra enabled auto-merge July 19, 2024 15:29
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 19, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 19, 2024
@ganfra ganfra merged commit a27d276 into develop Jul 19, 2024
34 checks passed
@ganfra ganfra deleted the feature/fga/compose_reaction_stability branch July 19, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants