Clear existing notification when a room is marked as read #3203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… since it actually contains only method to remove notifications.
bmarty
commented
Jul 16, 2024
| @@ -268,6 +270,7 @@ class RoomListPresenter @Inject constructor( | |||
| } | |||
|
|
|||
| private fun CoroutineScope.markAsRead(roomId: RoomId) = launch { | |||
| notificationCleaner.clearMessagesForRoom(client.sessionId, roomId) | |||
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3203 +/- ##
========================================
Coverage 76.14% 76.14%
========================================
Files 1645 1644 -1
Lines 38756 38758 +2
Branches 7501 7501
========================================
+ Hits 29510 29512 +2
+ Misses 5351 5350 -1
- Partials 3895 3896 +1 ☔ View full report in Codecov by Sentry. |
bmarty
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
ganfra
approved these changes
Jul 16, 2024
bmarty
commented
Jul 16, 2024
| clearMessagesForRoomLambda.assertions().isCalledOnce() | ||
| .with(value(A_SESSION_ID), value(A_ROOM_ID)) | ||
| initialState.eventSink.invoke(RoomListEvents.MarkAsUnread(A_ROOM_ID_2)) | ||
| assertThat(room2.markAsReadCalls).isEqualTo(emptyList<ReceiptType>()) |
There was a problem hiding this comment.
Konsist test should have failed here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
First commit are cleanup and small rework.
Last commit is to clear existing notification when a room is marked as read
Motivation and context
Clear existing notification when a room is marked as read (context: #3184)
Screenshots / GIFs
Tests
Tested devices
Checklist