Skip to content

Fix tracing configuration in debug and nightlies #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 12, 2024
Merged

Fix tracing configuration in debug and nightlies #3019

merged 4 commits into from
Jun 12, 2024

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Jun 12, 2024 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Debug will now write the logs to disk too.
  • Nightly will be able to customise tracing filters.
  • Improved the configure tracing and bug report screens.

Motivation and context

Fixes #3016.

Tests

  • Check bug reports uploaded from the debug build contain all the logs.
  • Check nightly build can customize their filters (they're not the default ones when the report is received).

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp
Fix tracing configuration in debug and nightlies:
ffebe02 
- Debug will now write the logs to disk too.
- Nightly will be able to customise tracing filters.
- Improved the configure tracing and bug report screens.
@jmartinesp jmartinesp requested a review from a team as a code owner June 12, 2024 09:39
@jmartinesp jmartinesp requested review from ganfra and removed request for a team June 12, 2024 09:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/qrxFEd

ganfra
ganfra approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 12, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) June 12, 2024 10:07
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 12, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jmartinesp jmartinesp merged commit 55a1ac4 into develop Jun 12, 2024
24 checks passed
@jmartinesp jmartinesp deleted the fix/jme/tracing-filters-in-debug-and-nightly branch June 12, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganfra ganfra ganfra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always write log files even in debug builds
2 participants
@jmartinesp @ganfra