Feature : First iteration of message queuing #3011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… retrySendMessage.
jmartinesp
approved these changes
Jun 11, 2024
| * Enables or disables the sending queue, according to the given parameter. | ||
| * | ||
| * The sending queue automatically disables itself whenever sending an | ||
| * event with it failed (e.g., sending an event via the Timeline, |
There was a problem hiding this comment.
Very tiny nit: unclosed parenthesis 😅 .
| editItem = it, | ||
| ) | ||
| } | ||
| specialModeEventTimelineItem = null |
There was a problem hiding this comment.
This isn't needed for the other when branch?
There was a problem hiding this comment.
Actually, we want to remove edition of local echo, as it'll break the ordering in the sending queue.
I'll update the api and usage.
ganfra
changed the base branch from
develop
to
feature/fga/update_rust_sdk_0.2.25
ganfra
merged commit c091813
into
feature/fga/update_rust_sdk_0.2.25
10 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
This is the first iteration of the message queuing, it includes :
Motivation and context
Closes #2863
Closes #2862
Screenshots / GIFs
Tests
Tested devices
Checklist