Skip to content

Timeline : use the new LiveBackPaginationStatus api #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Jun 7, 2024

This will handle the case where the timeline will back paginate on his own.

@ganfra ganfra marked this pull request as ready for review June 7, 2024 09:23
@ganfra ganfra requested a review from a team as a code owner June 7, 2024 09:23
@ganfra ganfra requested review from jmartinesp and removed request for a team June 7, 2024 09:23
Copy link
Contributor

github-actions bot commented Jun 7, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Jt1LMN

Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.54%. Comparing base (ab0a9c3) to head (d64b7ff).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2993   +/-   ##
========================================
  Coverage    75.54%   75.54%           
========================================
  Files         1589     1589           
  Lines        37583    37583           
  Branches      7298     7298           
========================================
  Hits         28392    28392           
  Misses        5373     5373           
  Partials      3818     3818           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not sure if we should have both the paginateBackwards result and the listener updating the pagination status at the same time. It's probably fine as they should return the same result.

@ganfra
Copy link
Member Author

ganfra commented Jun 7, 2024

LGTM, although I'm not sure if we should have both the paginateBackwards result and the listener updating the pagination status at the same time. It's probably fine as they should return the same result.

Yes it shouldn't change anything and as it's a StateFlow if the value are the same it won't emit anything downstream.

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 7, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 7, 2024
@ganfra ganfra merged commit 32cf20a into develop Jun 7, 2024
26 checks passed
@ganfra ganfra deleted the feature/fga/timeline_back_pagination_status branch June 7, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants