Skip to content

Try fixing OOM by changing GC and adding RAM to the kotlin compiler #2965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Jun 3, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Change the garbage collector to G1 which seems to perform better for large amounts of RAM.
  • Bump the amount of RAM available for the Kotiln Compiler too.
  • Add gradle cache to the Maestro flow, it should shorten the time needed to build the debug APK.
  • Bump max heap size for nightly reports as they seemed to be getting OOMs from time to time too.
  • Remove unnecessary module dependency from :features:call.

Motivation and context

I just want to get rid of the annoying OOM errors in the CI.

Tests

With some luck, every job in this PR should pass without OOMs.

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner June 3, 2024 07:07
@jmartinesp jmartinesp requested review from ganfra and removed request for a team June 3, 2024 07:07
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jun 3, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/BFE5HF

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.58%. Comparing base (b4b07d8) to head (a296894).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2965   +/-   ##
========================================
  Coverage    75.58%   75.58%           
========================================
  Files         1576     1576           
  Lines        37345    37345           
  Branches      7260     7260           
========================================
  Hits         28228    28228           
  Misses        5321     5321           
  Partials      3796     3796           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 3, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 3, 2024
@bmarty
Copy link
Member

bmarty commented Jun 3, 2024

image It used to take 10 minutes generally, that's nice!

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmartinesp jmartinesp merged commit 58c05ad into develop Jun 3, 2024
28 checks passed
@jmartinesp jmartinesp deleted the misc/jme/try-fixing-oom-again branch June 3, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants