-
Notifications
You must be signed in to change notification settings - Fork 232
Konsist upgrade #2948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Konsist upgrade #2948
Conversation
… in Composable MUST be Immutable or Stable`
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2948 +/- ##
===========================================
- Coverage 75.42% 75.41% -0.01%
===========================================
Files 1546 1546
Lines 36838 36838
Branches 7142 7144 +2
===========================================
- Hits 27785 27783 -2
Misses 5319 5319
- Partials 3734 3736 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Just a note about the Stable/Immutable sealed interfaces: I believe this was true a few versions of compose ago, but maybe we should check this again using the compose compiler reports and see if sealed interfaces can now autodetect its own stability.
EDIT: it seems like it still stands if the sealed interface is used outside the module, so it's not a bad idea to always check for this.
Replacement for #2529.
Fix API break and fix existing issues.