Skip to content

Konsist upgrade #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 31, 2024
Merged

Konsist upgrade #2948

merged 7 commits into from
May 31, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 29, 2024

Replacement for #2529.

Fix API break and fix existing issues.

@bmarty bmarty requested a review from a team as a code owner May 29, 2024 16:06
@bmarty bmarty requested review from jmartinesp and removed request for a team May 29, 2024 16:06
@ElementBot
Copy link
Collaborator

ElementBot commented May 29, 2024

Warnings
⚠️

gradle/libs.versions.toml#L12 - A newer version of androidx.core:core-ktx than 1.13.0 is available: 1.13.1

⚠️

gradle/libs.versions.toml#L18 - A newer version of androidx.datastore:datastore-preferences than 1.0.0 is available: 1.1.1

⚠️

gradle/libs.versions.toml#L21 - A newer version of androidx.lifecycle:lifecycle-runtime-ktx than 2.7.0 is available: 2.8.1

⚠️

gradle/libs.versions.toml#L22 - A newer version of androidx.activity:activity-compose than 1.8.2 is available: 1.9.0

⚠️

gradle/libs.versions.toml#L206 - A newer version of androidx.appcompat:appcompat than 1.6.1 is available: 1.7.0

Generated by 🚫 dangerJS against 569f3db

Copy link
Contributor

github-actions bot commented May 30, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/41v35X

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.41%. Comparing base (02d7c49) to head (569f3db).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2948      +/-   ##
===========================================
- Coverage    75.42%   75.41%   -0.01%     
===========================================
  Files         1546     1546              
  Lines        36838    36838              
  Branches      7142     7144       +2     
===========================================
- Hits         27785    27783       -2     
  Misses        5319     5319              
- Partials      3734     3736       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Just a note about the Stable/Immutable sealed interfaces: I believe this was true a few versions of compose ago, but maybe we should check this again using the compose compiler reports and see if sealed interfaces can now autodetect its own stability.

EDIT: it seems like it still stands if the sealed interface is used outside the module, so it's not a bad idea to always check for this.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 30, 2024
@bmarty bmarty enabled auto-merge May 30, 2024 11:14
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 30, 2024
@bmarty bmarty disabled auto-merge May 31, 2024 07:18
@bmarty bmarty merged commit c247169 into develop May 31, 2024
22 of 24 checks passed
@bmarty bmarty deleted the feature/bma/konsistUpgrade branch May 31, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants