Render blocked user data (behind a disabled feature flag)

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other : customer request

Content

When feature flag ShowBlockedUsersDetails is enabled, the application will render display name and avatar of blocked users. This can be useful for professional environment. Disabled by default on EXA.

Motivation and context

Customer request.

Screenshots / GIFs

See recorded ones.

Tests

• Enable the flag
• Block a user who have a display name and an avatar
• Navigate to the blocked users screen
• Observe that user avatar and display name is rendered.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/kfBGWq

[codecov]

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.16%. Comparing base (c511d59) to head (e18394a).

❗ Current head e18394a differs from pull request most recent head 21802be

Please upload reports for the commit 21802be to get more accurate results.

Files	Patch %	Lines
...ries/featureflag/impl/StaticFeatureFlagProvider.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2930      +/-   ##
===========================================
+ Coverage    75.15%   75.16%   +0.01%     
===========================================
  Files         1549     1549              
  Lines        36958    36974      +16     
  Branches      7178     7175       -3     
===========================================
+ Hits         27774    27792      +18     
- Misses        5429     5430       +1     
+ Partials      3755     3752       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

It should be alright as long as we don't modify the design for this screen in the future.

[jmartinesp]

1.misc? Should we use 2930.misc instead?

[bmarty]

oups, good catch 21802be

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud