Move push provider setting

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other : iterate on setting screens

Content

Move push provider setting to the "Notifications" screen and display it only when several push provider are available.

Motivation and context

Closes #2912

Screenshots / GIFs

See recorded ones

Tests

• Install ntfy and check that changing the push provider from the new location (Settings/Notifications) still works

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/FzuwW3

[codecov]

Codecov Report

Attention: Patch coverage is 88.31169% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 75.15%. Comparing base (d0b2233) to head (35a02a2).
Report is 11 commits behind head on develop.

Files	Patch %	Lines
...ces/impl/notifications/NotificationSettingsView.kt	73.07%	0 Missing and 7 partials ⚠️
...mpl/notifications/NotificationSettingsPresenter.kt	95.00%	0 Missing and 1 partial ⚠️
...lement/android/libraries/architecture/AsyncData.kt	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2928   +/-   ##
========================================
  Coverage    75.15%   75.15%           
========================================
  Files         1549     1549           
  Lines        36958    36973   +15     
  Branches      7178     7183    +5     
========================================
+ Hits         27774    27787   +13     
- Misses        5429     5431    +2     
  Partials      3755     3755           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

It LGTM in general, but I think there are some point which could be improved. Thanks for the changes!

[jmartinesp]

Should this be AsyncData instead?

[bmarty]

Could be but currentDistributorName is also updated when the user change the distributor, so it's also an AsyncAction... The boundaries between the 2 sealed interface is thin.

[jmartinesp]

I mean, having an 'action' called currentDistributorName is kind of weird, that's why I thought AsyncData fits it better. More so if we're going to use the LaunchedEffect to fetch it.

[bmarty]

OK: 9a24e7d

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud