Skip to content

Notifications: simplify the flow by removing persistence #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 29, 2024

Fix some docs and do some cleanup

d7e38cf
Select commit
Loading
Failed to load commit list.
Merged

Notifications: simplify the flow by removing persistence #2924

Fix some docs and do some cleanup
d7e38cf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed May 29, 2024 in 1s

68.45% of diff hit (target 75.24%)

View this Pull Request on Codecov

68.45% of diff hit (target 75.24%)

Annotations

Check warning on line 78 in features/call/src/main/kotlin/io/element/android/features/call/CallForegroundService.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

features/call/src/main/kotlin/io/element/android/features/call/CallForegroundService.kt#L78 

Added line #L78 was not covered by tests

Check warning on line 32 in features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/notifications/SystemNotificationsEnabledProvider.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/notifications/SystemNotificationsEnabledProvider.kt#L32 

Added line #L32 was not covered by tests

Check warning on line 35 in features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/notifications/SystemNotificationsEnabledProvider.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/notifications/SystemNotificationsEnabledProvider.kt#L35 

Added line #L35 was not covered by tests

Check warning on line 32 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/di/PushModule.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/di/PushModule.kt#L32 

Added line #L32 was not covered by tests

Check warning on line 71 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/ActiveNotificationsProvider.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/ActiveNotificationsProvider.kt#L71 

Added line #L71 was not covered by tests

Check warning on line 213 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/DefaultNotificationDrawerManager.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/DefaultNotificationDrawerManager.kt#L213 

Added line #L213 was not covered by tests

Check warning on line 226 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/DefaultNotificationDrawerManager.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/DefaultNotificationDrawerManager.kt#L223-L226 

Added lines #L223 - L226 were not covered by tests

Check warning on line 44 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L42-L44 

Added lines #L42 - L44 were not covered by tests

Check warning on line 54 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L54 

Added line #L54 was not covered by tests

Check warning on line 61 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L61 

Added line #L61 was not covered by tests

Check warning on line 64 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L64 

Added line #L64 was not covered by tests

Check warning on line 66 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L66 

Added line #L66 was not covered by tests

Check warning on line 69 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L69 

Added line #L69 was not covered by tests

Check warning on line 72 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L72 

Added line #L72 was not covered by tests

Check warning on line 76 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L76 

Added line #L76 was not covered by tests

Check warning on line 80 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L80 

Added line #L80 was not covered by tests

Check warning on line 86 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L86 

Added line #L86 was not covered by tests

Check warning on line 88 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L88 

Added line #L88 was not covered by tests

Check warning on line 91 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L91 

Added line #L91 was not covered by tests

Check warning on line 96 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L96 

Added line #L96 was not covered by tests

Check warning on line 98 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L98 

Added line #L98 was not covered by tests

Check warning on line 100 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L100 

Added line #L100 was not covered by tests

Check warning on line 102 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiver.kt#L102 

Added line #L102 was not covered by tests

Check warning on line 138 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationDataFactory.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationDataFactory.kt#L136-L138 

Added lines #L136 - L138 were not covered by tests

Check warning on line 141 in libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationDataFactory.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/NotificationDataFactory.kt#L140-L141 

Added lines #L140 - L141 were not covered by tests
View more details on Codecov