-
Notifications
You must be signed in to change notification settings - Fork 226
Add rich content listener to markdown text input #2918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rich content listener to markdown text input #2918
Conversation
Signed-off-by: Marco Antonio Alvarez <[email protected]>
Signed-off-by: Marco Antonio Alvarez <[email protected]>
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
Signed-off-by: Marco Antonio Alvarez <[email protected]>
Signed-off-by: Marco Antonio Alvarez <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2918 +/- ##
===========================================
- Coverage 75.25% 75.23% -0.02%
===========================================
Files 1550 1550
Lines 36966 36983 +17
Branches 7156 7160 +4
===========================================
+ Hits 27817 27825 +8
- Misses 5412 5421 +9
Partials 3737 3737 ☔ View full report in Codecov by Sentry. |
I'm not really convinced copying UriContentListener is the best approach 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it works like a charm!
) { | ||
val canUpdateState = !subcomposing | ||
|
||
// Copied from io.element.android.wysiwyg.internal.utils.UriContentListener | ||
class ReceiveUriContentListener( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should provide this to the RTE and not the other way around. I'll keep it in mind.
Type of change
Content
Fixes #2917
Added rich content listener to the markdown text input
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist