Reproducible build

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Using BuildConfig.VERSION_CODE break the reproducible build since the value will always end with 0, and should end with a digit depending on the architecture.

Motivation and context

Should fix the issue regarding diff in versionCode observed in #1418 (comment)

Screenshots / GIFs

NA

Tests

• NA

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/NfBZCv

[codecov]

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 75.23%. Comparing base (8f6190e) to head (f8aac80).
Report is 24 commits behind head on develop.

Files	Patch %	Lines
...droid/libraries/androidutils/system/SystemUtils.kt	0.00%	2 Missing ⚠️
...kotlin/io/element/android/x/ElementXApplication.kt	0.00%	1 Missing ⚠️
...c/main/kotlin/io/element/android/x/di/AppModule.kt	0.00%	1 Missing ⚠️
.../src/main/kotlin/io/element/android/x/info/Logs.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2911      +/-   ##
===========================================
- Coverage    75.23%   75.23%   -0.01%     
===========================================
  Files         1550     1550              
  Lines        36954    36956       +2     
  Branches      7152     7152              
===========================================
  Hits         27803    27803              
- Misses        5415     5417       +2     
  Partials      3736     3736              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ganfra]

Are we sure it does work for every OS and with R8?

[bmarty]

I do not think R8 will remove this from the manifest, since it's used by the system to manage application upgrade.