Skip to content

Fake classes name quality #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 27, 2024
Merged

Fake classes name quality #2900

merged 13 commits into from
May 27, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 23, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adding a Konsist test to ensure that Fake classes are correctly naming
Fix existing issues and ignore a few classes.

Motivation and context

Code quality, I have lost 2 seconds when looking for FakeMatrixAuthenticationService because it was name FakeAuthenticationService.

Screenshots / GIFs

Tests

  • NA

Tested devices

NA, if CI is happy, this is fine.

Checklist

@bmarty bmarty requested a review from a team as a code owner May 23, 2024 09:11
@bmarty bmarty requested review from ganfra and removed request for a team May 23, 2024 09:11
Copy link
Contributor

github-actions bot commented May 23, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/HjXfoJ

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26%. Comparing base (85c8a26) to head (7911fda).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2900   +/-   ##
========================================
  Coverage    75.26%   75.26%           
========================================
  Files         1550     1550           
  Lines        36922    36922           
  Branches      7148     7148           
========================================
  Hits         27789    27789           
  Misses        5398     5398           
  Partials      3735     3735           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty force-pushed the feature/bma/fakeClassesQuality branch from 972c723 to 7911fda Compare May 23, 2024 12:42
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bmarty bmarty merged commit afa90b8 into develop May 27, 2024
21 checks passed
@bmarty bmarty deleted the feature/bma/fakeClassesQuality branch May 27, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants