-
Notifications
You must be signed in to change notification settings - Fork 232
Fake classes name quality #2900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2900 +/- ##
========================================
Coverage 75.26% 75.26%
========================================
Files 1550 1550
Lines 36922 36922
Branches 7148 7148
========================================
Hits 27789 27789
Misses 5398 5398
Partials 3735 3735 ☔ View full report in Codecov by Sentry. |
972c723
to
7911fda
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Type of change
Content
Adding a Konsist test to ensure that Fake classes are correctly naming
Fix existing issues and ignore a few classes.
Motivation and context
Code quality, I have lost 2 seconds when looking for
FakeMatrixAuthenticationService
because it was nameFakeAuthenticationService
.Screenshots / GIFs
Tests
Tested devices
NA, if CI is happy, this is fine.
Checklist