Skip to content

Use member display names in membership timeline item text #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Add the affected user's display name to the membership change contents.
  • Use the display name in the timeline event text instead of the user id.

Motivation and context

Fixes #2866 .

Screenshots / GIFs

Before After
image image

Tests

  • Go into a room and invite / kick / ban, etc. some user.
  • Check on both sides the member's display name is always used.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner May 21, 2024 07:19
@jmartinesp jmartinesp requested review from ganfra and removed request for a team May 21, 2024 07:19
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/KjtFzx

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.30%. Comparing base (5d8cc80) to head (d7e5eba).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2883   +/-   ##
========================================
  Coverage    74.30%   74.30%           
========================================
  Files         1530     1530           
  Lines        36524    36526    +2     
  Branches      7054     7055    +1     
========================================
+ Hits         27140    27142    +2     
  Misses        5698     5698           
  Partials      3686     3686           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 21, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 21, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) May 21, 2024 08:05
@jmartinesp jmartinesp merged commit 8bd9880 into develop May 21, 2024
26 checks passed
@jmartinesp jmartinesp deleted the jme/fix/add-user-display-name-to-membership-change-events branch May 21, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"You invited %1$@" still shows a matrix id
2 participants