Skip to content

Try to fix CI quality flow #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 20, 2024
Merged

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented May 20, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Remove the onCheck value in the different Kover verify variants in case they're causing these failures. In any case, these are always called from other gradle tasks.
  • Split the quality checks flow into several smaller jobs to parallelise the work done and minimise memory usage.

Motivation and context

GH actions related to quality have been unreliable lately.

Tests

Let's see how the CI behaves.

Checklist

@jmartinesp jmartinesp requested a review from ganfra May 20, 2024 09:07
@jmartinesp jmartinesp requested a review from a team as a code owner May 20, 2024 09:07
@jmartinesp jmartinesp changed the title Try to fix CI quality step Try to fix CI quality flow May 20, 2024
Copy link
Contributor

github-actions bot commented May 20, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/9PuG9A

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I guess!

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.27%. Comparing base (bb96eea) to head (c0943ee).

Current head c0943ee differs from pull request most recent head 649c63d

Please upload reports for the commit 649c63d to get more accurate results.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2880   +/-   ##
========================================
  Coverage    74.27%   74.27%           
========================================
  Files         1530     1530           
  Lines        36521    36521           
  Branches      7053     7053           
========================================
+ Hits         27126    27127    +1     
  Misses        5708     5708           
+ Partials      3687     3686    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jmartinesp jmartinesp merged commit 29723a6 into develop May 20, 2024
19 checks passed
@jmartinesp jmartinesp deleted the fix/jme/ci-quality-step-failing branch May 20, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants