Restore legacy shrinking configuration for AGP 8.4.x

[jmartinesp]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Disable the new way of shrinking code added in AGP 8.4.0.

Motivation and context

It's causing issues with release builds and no changes in proguard rules seem to fix them.

i.e.

ERROR: Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in /Users/jorge/Developer/Element/element-x-android/app/build/outputs/mapping/gplayRelease/missing_rules.txt.
ERROR: R8: Missing class io.element.android.libraries.designsystem.atomic.atoms.ElementLogoAtomSize (referenced from: void io.element.android.features.ftue.impl.welcome.WelcomeViewKt$WelcomeView$2.invoke(androidx.compose.runtime.Composer, int) and 1 other context)

That missing_rules.txt files just contains -dontwarn entries that do remove the errors while building, but then the classes aren't present in the resulting APK and the app instantly crashes on boot.

Adding --keep class io.element.android.foo.SomeMissingClass { *; } does nothing either.

Tests

We should be able to build nightlies again with this change.

This nightly build flow based on this branch built the apk just fine: https://github.com/element-hq/element-x-android/actions/runs/9124298023/job/25089536772

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/T3yxGU

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.06%. Comparing base (9d4cfd8) to head (e01b9ad).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2867   +/-   ##
========================================
  Coverage    74.06%   74.06%           
========================================
  Files         1530     1530           
  Lines        36542    36542           
  Branches      7055     7055           
========================================
  Hits         27064    27064           
  Misses        5791     5791           
  Partials      3687     3687           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

LGTM, thanks.

[bmarty]

Weird that the value is false, it would be more logical to have true, but https://developer.android.com/build/releases/gradle-plugin#library-classes-shrunk is not clear about it.

If it fixes the issue, that's fine!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud