-
Notifications
You must be signed in to change notification settings - Fork 226
UX cleanup: reorder options in the main settings screen #2802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2802 +/- ##
===========================================
- Coverage 73.44% 73.43% -0.01%
===========================================
Files 1523 1523
Lines 36513 36532 +19
Branches 7032 7042 +10
===========================================
+ Hits 26816 26827 +11
+ Misses 6028 6026 -2
- Partials 3669 3679 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. Just a remark related to this screen Footer, but not from this PR. Can be handled separately if you prefer.
onSignOutClicked = onSignOutClicked, | ||
) | ||
|
||
Footer( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not from this PR, but since you're updating this screen, can you add some horizontal padding to the footer? With QRCode login and OIDC management, we can have long deviceId, and so it can touch the edge of the screen. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, it will take just a sec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Type of change
Content
Motivation and context
Closes #2801.
Screenshots / GIFs
Tests
Tested devices
Checklist