Skip to content

UX cleanup: reorder options in the main settings screen #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2024

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : UX cleanup

Content

  • Rearrange the options in the settings screen into sections following a new ordering.

Motivation and context

Closes #2801.

Screenshots / GIFs

Before After

Tests

  • Open the settings screen.
  • Check the order and section grouping is the right one.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner May 6, 2024 14:33
@jmartinesp jmartinesp requested review from bmarty and removed request for a team May 6, 2024 14:33
Copy link
Contributor

github-actions bot commented May 6, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/5arLAW

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 73.43%. Comparing base (3435803) to head (0e6d7b1).

Files Patch % Lines
...tures/preferences/impl/root/PreferencesRootView.kt 71.42% 1 Missing and 19 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2802      +/-   ##
===========================================
- Coverage    73.44%   73.43%   -0.01%     
===========================================
  Files         1523     1523              
  Lines        36513    36532      +19     
  Branches      7032     7042      +10     
===========================================
+ Hits         26816    26827      +11     
+ Misses        6028     6026       -2     
- Partials      3669     3679      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Just a remark related to this screen Footer, but not from this PR. Can be handled separately if you prefer.

onSignOutClicked = onSignOutClicked,
)

Footer(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not from this PR, but since you're updating this screen, can you add some horizontal padding to the footer? With QRCode login and OIDC management, we can have long deviceId, and so it can touch the edge of the screen. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it will take just a sec.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

sonarqubecloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 6, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 6, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) May 6, 2024 15:02
@jmartinesp jmartinesp merged commit e82e333 into develop May 6, 2024
17 of 19 checks passed
@jmartinesp jmartinesp deleted the misc/jme/2801-cleanup-settings-screen branch May 6, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Cleanup: settings screen
2 participants