Skip to content

Feature/bma/external permalink fix #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 6, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Don't intercept mas.element.io domain with our intent filters

Also this PR revert the change on ElementCallActivity intent filter, since it's not necessary to go through the MainActivity anymore.

Replacement for #2794

Note Can be merged, but external link handling will not work on Android 12+ until the assetlinks.json file are ready server side.

Motivation and context

Current implementation of external link handling (added in #2776) was catching mas.element.io links and so prevent Matrix user on element.io from signing in.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner May 6, 2024 09:42
@bmarty bmarty requested review from jmartinesp and removed request for a team May 6, 2024 09:42
Copy link

sonarqubecloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented May 6, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ciVSd9

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.44%. Comparing base (86838e7) to head (19a97c6).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2798      +/-   ##
===========================================
+ Coverage    73.41%   73.44%   +0.03%     
===========================================
  Files         1523     1523              
  Lines        36528    36513      -15     
  Branches      7038     7032       -6     
===========================================
  Hits         26816    26816              
+ Misses        6043     6028      -15     
  Partials      3669     3669              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it seems to work fine for me both on Android 12 and Android 14 - although this might be because the auto-verify was done before the change and it's kept in the Android settings.

@bmarty bmarty merged commit 6048b10 into develop May 6, 2024
17 checks passed
@bmarty bmarty deleted the feature/bma/externalPermalinkFix branch May 6, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants