Skip to content

Escape paths in build_rust_sdk script #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2024

Conversation

hughns
Copy link
Member

@hughns hughns commented May 1, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

This allows the build_rust_sdk.sh script to run on a file system path that contains a space.

Motivation and context

Screenshots / GIFs

Tests

  • Run tools/sdk/build_rust_sdk.sh

Tested devices

n/a

  • Physical
  • Emulator
  • OS version(s):

Checklist

@hughns hughns requested a review from a team as a code owner May 1, 2024 09:05
@hughns hughns requested review from bmarty and removed request for a team May 1, 2024 09:05
Copy link
Contributor

github-actions bot commented May 1, 2024

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • There is a changelog entry in the changelog.d folder with the Towncrier format.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.47%. Comparing base (9880579) to head (fd54aeb).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2779   +/-   ##
========================================
  Coverage    73.47%   73.47%           
========================================
  Files         1517     1517           
  Lines        36422    36422           
  Branches      7012     7012           
========================================
  Hits         26760    26760           
  Misses        5997     5997           
  Partials      3665     3665           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frebib
Copy link
Contributor

frebib commented May 1, 2024

It's probably worth shellchecking the whole script. I think there are other similar issues in there last I looked

@hughns
Copy link
Member Author

hughns commented May 1, 2024

It's probably worth shellchecking the whole script. I think there are other similar issues in there last I looked

I've made #2781 to explore the broader question of using shellcheck in the project.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty merged commit 4c6bac8 into element-hq:develop May 2, 2024
14 of 15 checks passed
@hughns hughns deleted the build-sdk-fix branch May 8, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants