Skip to content

Split building the debug APK in CI #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Apr 30, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Make the build.yml CI flow build gplay and fdroid variants separately.
  • Lower the max heap size to 7GB to avoid the flow from cancelling itself.
  • Only upload the universal APKs as result artefacts, uploading every single apk takes a long time.

Motivation and context

Building them both at the same time is causing OOM errors and automatic cancellation of the CI flow.

Tests

If the CI works, hopefully it means it's fixed.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner April 30, 2024 15:16
@jmartinesp jmartinesp requested review from bmarty and removed request for a team April 30, 2024 15:16
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/oZtTJw

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.47%. Comparing base (6d924c3) to head (08658a7).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2774       +/-   ##
============================================
+ Coverage         0   73.47%   +73.47%     
============================================
  Files            0     1517     +1517     
  Lines            0    36422    +36422     
  Branches         0     7012     +7012     
============================================
+ Hits             0    26760    +26760     
- Misses           0     5997     +5997     
- Partials         0     3665     +3665     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this!

@jmartinesp jmartinesp merged commit 9880579 into develop Apr 30, 2024
17 checks passed
@jmartinesp jmartinesp deleted the misc/jme/split-debug-apk-build branch April 30, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants