Skip to content

Remove flag RoomListFilters. #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 25, 2024

This is also fixing the filter reset issue when going back to the room list.

@bmarty bmarty requested a review from a team as a code owner April 25, 2024 12:55
@bmarty bmarty requested review from ganfra and removed request for a team April 25, 2024 12:55
This is also fixing the filter reset issue when going back to the room list.
@bmarty bmarty force-pushed the feature/bma/removeFlagRoomListFilters branch from a6a0810 to 268c196 Compare April 25, 2024 13:55
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 25, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 25, 2024
Copy link
Contributor

github-actions bot commented Apr 25, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7S7NVr

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 25, 2024
@bmarty bmarty enabled auto-merge April 25, 2024 14:06
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 25, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.60%. Comparing base (7397df8) to head (25751ef).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2753      +/-   ##
===========================================
- Coverage    73.61%   73.60%   -0.01%     
===========================================
  Files         1504     1504              
  Lines        36075    36060      -15     
  Branches      6958     6958              
===========================================
- Hits         26555    26541      -14     
+ Misses        5871     5870       -1     
  Partials      3649     3649              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty disabled auto-merge April 25, 2024 15:19
@bmarty bmarty merged commit 1fc01c9 into develop Apr 25, 2024
16 checks passed
@bmarty bmarty deleted the feature/bma/removeFlagRoomListFilters branch April 25, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants