Skip to content

Gh pages fix and Localazy fix #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Gh pages fix and Localazy fix #2705

merged 3 commits into from
Apr 15, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 15, 2024

Hide the date picker on EXA Gallery, it cannot work as expected.

Also fix how we get date change for new screenshot.

It will fix the Localazy sync, which is broken: https://github.com/element-hq/element-x-android/actions/runs/8682228226/job/23806432412

Once this PR is merged, I will manually trigger a new Localazy sync.

bmarty added 3 commits April 15, 2024 11:29
…ng the URL parameter only.

I believe this will not work in prod since the file are copied after the data.js is generated.
@bmarty bmarty requested a review from a team as a code owner April 15, 2024 09:41
@bmarty bmarty requested review from ganfra and removed request for a team April 15, 2024 09:41
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.57%. Comparing base (42dd04f) to head (5150c77).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2705   +/-   ##
========================================
  Coverage    73.57%   73.57%           
========================================
  Files         1461     1461           
  Lines        35337    35337           
  Branches      6793     6793           
========================================
  Hits         26000    26000           
  Misses        5798     5798           
  Partials      3539     3539           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/UFQQD6

@bmarty bmarty merged commit 4be4129 into develop Apr 15, 2024
@bmarty bmarty deleted the feature/bma/ghPagesFix branch April 15, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants