Skip to content

Remove some dead code and add tests on RetrySendMessageMenu #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 5, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 4, 2024

Also do some renaming for code clarity.

image

@bmarty bmarty requested a review from a team as a code owner April 4, 2024 14:18
@bmarty bmarty requested review from jmartinesp and removed request for a team April 4, 2024 14:18
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Apr 4, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Udppfs

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.45%. Comparing base (476a54c) to head (20ebb5e).

Files Patch % Lines
...e/components/retrysendmenu/RetrySendMessageMenu.kt 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2659      +/-   ##
===========================================
+ Coverage    73.37%   73.45%   +0.07%     
===========================================
  Files         1458     1455       -3     
  Lines        35168    35105      -63     
  Branches      6750     6733      -17     
===========================================
- Hits         25805    25786      -19     
+ Misses        5850     5804      -46     
- Partials      3513     3515       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit 705490d into develop Apr 5, 2024
@bmarty bmarty deleted the feature/bma/moreTest branch April 5, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants