Skip to content

Implement MSC2530 #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

surakin
Copy link
Contributor

@surakin surakin commented Mar 10, 2024

Depends on matrix-org/matrix-rust-sdk#3171
Fixes #2521

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Show body as image caption, per MSC 2530

Motivation and context

Caption as a different message doesn't look this good

Screenshots / GIFs

image

Tests

  • Send an image using with a bridge/client with body as caption enabled (mautrix-whatsapp for example)
  • See how the image is displayed with caption instead of in a separate message.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Signed-off-by: Marco Antonio Alvarez <[email protected]>
Copy link
Contributor

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • There is a changelog entry in the changelog.d folder with the Towncrier format.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@surakin
Copy link
Contributor Author

surakin commented Mar 10, 2024

Not convinced about how that column looks like, but it's sunday so I'll keep trying later

@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Mar 11, 2024
surakin added 8 commits March 14, 2024 18:16
Signed-off-by: Marco Antonio Alvarez <[email protected]>
added video captions

Signed-off-by: Marco Antonio Alvarez <[email protected]>
Signed-off-by: Marco Antonio Alvarez <[email protected]>
Signed-off-by: Marco Antonio Alvarez <[email protected]>
Signed-off-by: Marco Antonio Alvarez <[email protected]>
Signed-off-by: Marco Antonio Alvarez <[email protected]>
@surakin
Copy link
Contributor Author

surakin commented Mar 14, 2024

The 'Record Screenshots' action seems be failing but I don't see any error related to this change on its log 🤔

@surakin surakin marked this pull request as ready for review March 14, 2024 20:33
@surakin surakin requested a review from a team as a code owner March 14, 2024 20:33
@surakin surakin requested review from ganfra and removed request for a team March 14, 2024 20:33
@jmartinesp jmartinesp requested review from jmartinesp and removed request for ganfra March 19, 2024 13:17
@jmartinesp
Copy link
Member

Thanks for the changes! I'll merge it to a branch of mine where I can tweak these changes a bit so they fit a bit better our layout.

@jmartinesp jmartinesp changed the base branch from develop to feature/add-caption-to-image-and-video-events March 19, 2024 13:18
@jmartinesp jmartinesp merged commit 5b2a45f into element-hq:feature/add-caption-to-image-and-video-events Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MSC2530 (Body field as media caption)
3 participants