Skip to content

Don't show body in replies to voice messages but rather show "Voice message" string #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

julioromano
Copy link

@julioromano julioromano commented Oct 27, 2023

@julioromano julioromano self-assigned this Oct 27, 2023
@ElementBot
Copy link
Collaborator

ElementBot commented Oct 27, 2023

Warnings
⚠️

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListView.kt#L37 - Using a material import while also using the material3 library

⚠️

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListView.kt#L38 - Using a material import while also using the material3 library

Generated by 🚫 dangerJS against c16a69b

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/HddpCp

@julioromano julioromano force-pushed the julioromano/removeUuidFromReplies branch 2 times, most recently from 761fd39 to 8a9856d Compare October 27, 2023 19:24
@julioromano julioromano changed the title WIP: Don't show body in replies to voice messages but rather show "Vo… Don't show body in replies to voice messages but rather show "Voice message" string Oct 27, 2023
@julioromano julioromano marked this pull request as ready for review October 27, 2023 19:25
@julioromano julioromano requested a review from a team as a code owner October 27, 2023 19:25
@julioromano julioromano requested review from bmarty and removed request for a team October 27, 2023 19:25
@julioromano
Copy link
Author

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (21499a2) 63.69% compared to head (cb5899d) 63.69%.
Report is 2 commits behind head on develop.

❗ Current head cb5899d differs from pull request most recent head c16a69b. Consider uploading reports for the commit c16a69b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1673      +/-   ##
===========================================
- Coverage    63.69%   63.69%   -0.01%     
===========================================
  Files         1267     1267              
  Lines        32798    32800       +2     
  Branches      6795     6797       +2     
===========================================
- Hits         20892    20891       -1     
- Misses        8772     8773       +1     
- Partials      3134     3136       +2     
Files Coverage Δ
...ndroid/features/messages/impl/MessagesPresenter.kt 81.62% <0.00%> (ø)
...eatures/messages/impl/actionlist/ActionListView.kt 62.71% <0.00%> (ø)
...s/impl/timeline/components/TimelineItemEventRow.kt 60.25% <0.00%> (-0.58%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julioromano julioromano force-pushed the julioromano/removeUuidFromReplies branch from 25f508a to c16a69b Compare October 27, 2023 21:14
@julioromano julioromano enabled auto-merge (squash) October 27, 2023 21:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julioromano julioromano merged commit 563aaa6 into develop Oct 27, 2023
@julioromano julioromano deleted the julioromano/removeUuidFromReplies branch October 27, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants