Skip to content

Add missing screenshots in TimelineView #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

julioromano
Copy link

@julioromano julioromano commented Oct 27, 2023

Add audio, voice and poll screenshots to TimelineView which were missing.

@julioromano julioromano self-assigned this Oct 27, 2023
@julioromano julioromano requested a review from a team as a code owner October 27, 2023 09:37
@julioromano julioromano requested review from ganfra and jmartinesp and removed request for a team and ganfra October 27, 2023 09:37
@julioromano
Copy link
Author

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/FDf4k5

@julioromano
Copy link
Author

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

onSwipeToReply = {},
)
CompositionLocalProvider(
LocalTimelineItemPresenterFactories provides aFakeTimelineItemPresenterFactory(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@jmartinesp
Copy link
Member

jmartinesp commented Oct 27, 2023

New screenshots, sorry for the conflicts: https://github.com/vector-im/element-x-android/actions/runs/6666160303

@jmartinesp jmartinesp force-pushed the julioromano/timelinescreenshots branch from 248bea2 to caa2d31 Compare October 27, 2023 10:42
@julioromano julioromano enabled auto-merge (squash) October 27, 2023 11:01
@julioromano julioromano force-pushed the julioromano/timelinescreenshots branch 2 times, most recently from deb1349 to 36f2910 Compare October 27, 2023 11:04
@julioromano julioromano disabled auto-merge October 27, 2023 11:04
@julioromano julioromano enabled auto-merge (squash) October 27, 2023 11:08
Squashed commits:
[f51887591] Fix detekt issues
[0deddedc6] Add timeline screenshots for voice messages
[705ed69cc] Add missing screenshots in TimelineView
@julioromano julioromano force-pushed the julioromano/timelinescreenshots branch from 36f2910 to 1178a32 Compare October 27, 2023 11:39
@julioromano
Copy link
Author

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julioromano julioromano merged commit a6e4644 into develop Oct 27, 2023
@julioromano julioromano deleted the julioromano/timelinescreenshots branch October 27, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants