Skip to content

Add more tests, particularly to the room list diffing #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Oct 6, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : improve tests in the matrix library modules.

Content

  • Adds some test for mapping AuthenticationExceptions between Rust and Kotlin.
  • Adds tests for RoomSummaryListProcessor.

Motivation and context

Test more un-tested parts of the app, improve coverage.

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner October 6, 2023 11:53
@jmartinesp jmartinesp requested review from julioromano and removed request for a team October 6, 2023 11:53
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/iKze9a

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (daf46d7) 58.70% compared to head (eab221d) 58.96%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1508      +/-   ##
===========================================
+ Coverage    58.70%   58.96%   +0.25%     
===========================================
  Files         1133     1133              
  Lines        30300    30301       +1     
  Branches      6215     6215              
===========================================
+ Hits         17789    17868      +79     
+ Misses        9840     9760      -80     
- Partials      2671     2673       +2     
Files Coverage Δ
...raries/matrix/impl/auth/AuthenticationException.kt 100.00% <100.00%> (+100.00%) ⬆️
...braries/matrix/impl/roomlist/RoomListExtensions.kt 0.00% <ø> (ø)
...s/matrix/impl/roomlist/RoomSummaryListProcessor.kt 76.31% <100.00%> (+76.31%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jmartinesp jmartinesp merged commit 776d935 into develop Oct 6, 2023
@jmartinesp jmartinesp deleted the chore/jme/improve-coverage-auth-and-roomsummarylistprocessor branch October 6, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants