Skip to content

Add feature flag for voice messages #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Oct 6, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add feature flag for voice messages.

Motivation and context

Screenshots / GIFs

Tests

N/A

Tested devices

  • Physical
  • Emulator
  • OS version(s): N/A

Checklist

@jonnyandrew jonnyandrew marked this pull request as ready for review October 6, 2023 10:46
@jonnyandrew jonnyandrew requested a review from a team as a code owner October 6, 2023 10:46
@jonnyandrew jonnyandrew requested review from bmarty and removed request for a team October 6, 2023 10:46
@jonnyandrew
Copy link
Contributor Author

cc @julioromano

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/MnXpVC

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (daf46d7) 58.70% compared to head (12314b3) 58.71%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1507   +/-   ##
========================================
  Coverage    58.70%   58.71%           
========================================
  Files         1133     1133           
  Lines        30300    30306    +6     
  Branches      6215     6215           
========================================
+ Hits         17789    17794    +5     
- Misses        9840     9841    +1     
  Partials      2671     2671           
Files Coverage Δ
.../android/libraries/featureflag/api/FeatureFlags.kt 100.00% <100.00%> (ø)
...ries/featureflag/impl/StaticFeatureFlagProvider.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonnyandrew jonnyandrew merged commit 9e73d6d into develop Oct 6, 2023
@jonnyandrew jonnyandrew deleted the jonny/voice-feature-flag branch October 6, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants