Skip to content

Fix composer options bottom sheet position #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Sep 29, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Move the composer options / attachments bottom sheet up one level in the UI hierarchy so that it is outside of the composer bottom sheet.

Motivation and context

Fixes an issue where the attachments dialog is displayed in the wrong position and cannot be swiped to dismiss (see screenshots).

The issue isn't presenting as severely when I test on my physical device as when tested in an emulator (screenshots below).

Screenshots / GIFs

Before

Before.webm

After

After.webm

Tests

  • Go to composer
  • Enter text and ensure keyboard is open
  • Open the composer options / attachments menu and dismiss
  • Close the keyboard
  • Open the composer options / attachments menu and dismiss

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tUg2K1

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fc20569) 58.21% compared to head (5840c8c) 58.20%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1469      +/-   ##
===========================================
- Coverage    58.21%   58.20%   -0.01%     
===========================================
  Files         1133     1133              
  Lines        30266    30259       -7     
  Branches      6192     6193       +1     
===========================================
- Hits         17619    17613       -6     
  Misses       10008    10008              
+ Partials      2639     2638       -1     
Files Coverage Δ
...ent/android/features/messages/impl/MessagesView.kt 59.34% <100.00%> (+0.57%) ⬆️
...ssages/impl/messagecomposer/MessageComposerView.kt 63.15% <92.30%> (-1.43%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonnyandrew jonnyandrew marked this pull request as ready for review September 29, 2023 16:15
@jonnyandrew jonnyandrew requested a review from a team as a code owner September 29, 2023 16:15
@jonnyandrew jonnyandrew requested review from ganfra and removed request for a team September 29, 2023 16:15
@jonnyandrew jonnyandrew changed the title Fix composer options dialog position Fix composer options bottom sheet position Sep 29, 2023
@jonnyandrew jonnyandrew merged commit 6bca8be into develop Sep 29, 2023
@jonnyandrew jonnyandrew deleted the jonny/fix-dialog-position branch September 29, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants