Skip to content

Display poll notifications in the notification drawer #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2023
Merged

Display poll notifications in the notification drawer #1467

merged 2 commits into from
Sep 29, 2023

Conversation

julioromano
Copy link

Display notifications for polls as if they were message events but prepending the poll question with "Poll: " as we do in the room summary.

@julioromano julioromano requested a review from a team as a code owner September 29, 2023 12:37
@julioromano julioromano requested review from bmarty and removed request for a team September 29, 2023 12:37
@julioromano julioromano self-assigned this Sep 29, 2023
@julioromano julioromano mentioned this pull request Sep 29, 2023
Closed
6 tasks
Display poll notifications in the notification drawer
a09e91d 
Display notifications for polls as if they were message events.
@julioromano julioromano force-pushed the julioromano/polls_notif branch from c1b3cc2 to a09e91d Compare September 29, 2023 12:39
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pDQ3Va

@codecov
Copy link

codecov bot commented Sep 29, 2023 •
edited
Loading

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (53cf82f) 58.24% compared to head (353b704) 58.21%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1467      +/-   ##
===========================================
- Coverage    58.24%   58.21%   -0.03%     
===========================================
  Files         1133     1133              
  Lines        30252    30266      +14     
  Branches      6192     6192              
===========================================
  Hits         17619    17619              
- Misses        9994    10008      +14     
  Partials      2639     2639
Files Coverage Δ
...cation/TimelineEventToNotificationContentMapper.kt 0.00% <0.00%> (ø)
...raries/matrix/api/notification/NotificationData.kt 0.00% <0.00%> (ø)
...push/impl/notifications/NotifiableEventResolver.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmarty
bmarty approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.../main/kotlin/io/element/android/libraries/push/impl/notifications/NotifiableEventResolver.kt Outdated
timestamp = this.timestamp,
senderName = senderDisplayName,
body = stringProvider.getString(CommonStrings.common_poll_summary, content.question),
imageUriString = this.contentUrl,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess in the case of a poll this.contentUrl will always be null.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got me, I believe the same. Should I just hardcode a null here?

@julioromano
Copy link
Author

Hardcoded a null

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julioromano julioromano merged commit fc20569 into develop Sep 29, 2023
@julioromano julioromano deleted the julioromano/polls_notif branch September 29, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees

@julioromano julioromano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julioromano @bmarty