-
Notifications
You must be signed in to change notification settings - Fork 232
String duplicate #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String duplicate #1454
Conversation
@@ -124,4 +124,7 @@ | |||
|
|||
<!-- DI --> | |||
<!-- issue id="JvmStaticProvidesInObjectDetector" severity="error" /--> | |||
|
|||
<!-- Compose --> | |||
<issue id="UnnecessaryComposedModifier" severity="error" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit (a lot) unrelated, but since I was looking at lint reports, I took the opportunity to also change this, in a dedicated commit.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
@@ -1,5 +1,8 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2"> | |||
<string name="screen_advanced_settings_developer_mode">"Developer mode"</string> | |||
<string name="screen_advanced_settings_developer_mode_description">"By enabling you get access to features and functions for developers."</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either add a comma after "by enabling", or I think a better string would be "Enable to have access to features and functionality for developers"
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1454 +/- ##
========================================
Coverage 57.92% 57.92%
========================================
Files 1129 1129
Lines 30046 30045 -1
Branches 6144 6143 -1
========================================
Hits 17404 17404
Misses 10031 10031
+ Partials 2611 2610 -1
☔ View full report in Codecov by Sentry. |
be0215b
to
a4e656e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Type of change
Content
Start reducing number of duplicated strings #1356
Also iterate on some string (element-hq/element-meta#2042)
Motivation and context
Less duplicated string for less divergence in translations.
Screenshots / GIFs
Tests
Tested devices
Checklist