Skip to content

String duplicate #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 29, 2023
Merged

String duplicate #1454

merged 10 commits into from
Sep 29, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 28, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Start reducing number of duplicated strings #1356
Also iterate on some string (element-hq/element-meta#2042)

Motivation and context

Less duplicated string for less divergence in translations.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner September 28, 2023 16:05
@bmarty bmarty requested review from julioromano and removed request for a team September 28, 2023 16:05
@@ -124,4 +124,7 @@

<!-- DI -->
<!-- issue id="JvmStaticProvidesInObjectDetector" severity="error" /-->

<!-- Compose -->
<issue id="UnnecessaryComposedModifier" severity="error" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit (a lot) unrelated, but since I was looking at lint reports, I took the opportunity to also change this, in a dedicated commit.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/utRmwv

@@ -1,5 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
<string name="screen_advanced_settings_developer_mode">"Developer mode"</string>
<string name="screen_advanced_settings_developer_mode_description">"By enabling you get access to features and functions for developers."</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either add a comma after "by enabling", or I think a better string would be "Enable to have access to features and functionality for developers"

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ce96c73) 57.92% compared to head (be0215b) 57.92%.
Report is 3 commits behind head on develop.

❗ Current head be0215b differs from pull request most recent head cd90953. Consider uploading reports for the commit cd90953 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1454   +/-   ##
========================================
  Coverage    57.92%   57.92%           
========================================
  Files         1129     1129           
  Lines        30046    30045    -1     
  Branches      6144     6143    -1     
========================================
  Hits         17404    17404           
  Misses       10031    10031           
+ Partials      2611     2610    -1     
Files Coverage Δ
...nfirmaccountprovider/ConfirmAccountProviderView.kt 36.48% <100.00%> (ø)
...in/impl/screens/loginpassword/LoginPasswordView.kt 65.94% <100.00%> (ø)
...e/components/retrysendmenu/RetrySendMessageMenu.kt 28.26% <ø> (ø)
.../preferences/impl/advanced/AdvancedSettingsView.kt 45.45% <100.00%> (ø)
...droid/features/roomdetails/impl/RoomDetailsView.kt 56.50% <100.00%> (ø)
...res/roomdetails/impl/members/RoomMemberListView.kt 57.39% <ø> (ø)
...t/android/libraries/designsystem/modifiers/Blur.kt 72.97% <100.00%> (+1.92%) ⬆️
...atures/verifysession/impl/VerifySelfSessionView.kt 65.44% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty force-pushed the feature/bma/stringDuplicate branch from be0215b to a4e656e Compare September 29, 2023 07:02
@ElementBot
Copy link
Collaborator

ElementBot commented Sep 29, 2023

Warnings
⚠️

tools/lint/lint.xml#L34 - Issue IconExpectedSize was configured with severity error in uitests, but was not enabled (or was disabled) in library di

⚠️

tools/lint/lint.xml#L73 - Issue NegativeMargin was configured with severity error in uitests, but was not enabled (or was disabled) in library di

⚠️

tools/lint/lint.xml#L87 - Issue KotlinPropertyAccess was configured with severity error in uitests, but was not enabled (or was disabled) in library di

⚠️

tools/lint/lint.xml#L123 - Unknown issue id "EnsureInitializerMetadata"

⚠️

tools/lint/lint.xml#L129 - Unknown issue id "UnnecessaryComposedModifier"

Generated by 🚫 dangerJS against cd90953

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bmarty bmarty enabled auto-merge September 29, 2023 07:24
@bmarty bmarty merged commit 496601a into develop Sep 29, 2023
@bmarty bmarty deleted the feature/bma/stringDuplicate branch September 29, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants