Skip to content

Update dependency org.matrix.rustcomponents:sdk-android to v0.1.58 #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 26, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.matrix.rustcomponents:sdk-android 0.1.57 -> 0.1.58 age adoption passing confidence

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner September 26, 2023 18:05
@renovate renovate bot requested review from bmarty and removed request for a team September 26, 2023 18:05
@renovate renovate bot added the PR-Dependencies Pull requests that update a dependency file label Sep 26, 2023
@ElementBot
Copy link
Collaborator

ElementBot commented Sep 26, 2023

Warnings
⚠️

gradle/libs.versions.toml#L99 - A newer version of androidx.compose.material3:material3 than 1.2.0-alpha06 is available: 1.2.0-alpha08

Generated by 🚫 dangerJS against c9c7af6

@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Sep 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/upftoK

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (8e24d59) 58.00% compared to head (a192a88) 57.89%.
Report is 5 commits behind head on develop.

❗ Current head a192a88 differs from pull request most recent head c9c7af6. Consider uploading reports for the commit c9c7af6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1437      +/-   ##
===========================================
- Coverage    58.00%   57.89%   -0.11%     
===========================================
  Files         1129     1129              
  Lines        29971    30047      +76     
  Branches      6101     6141      +40     
===========================================
+ Hits         17385    17397      +12     
- Misses        9977    10041      +64     
  Partials      2609     2609              
Files Coverage Δ
...nt/android/libraries/matrix/api/room/MatrixRoom.kt 28.57% <ø> (ø)
...droid/libraries/matrix/test/room/FakeMatrixRoom.kt 90.82% <100.00%> (+0.08%) ⬆️
...s/impl/messagecomposer/MessageComposerPresenter.kt 93.01% <90.90%> (-0.14%) ⬇️
...raries/matrix/api/notification/NotificationData.kt 0.00% <0.00%> (ø)
...cation/TimelineEventToNotificationContentMapper.kt 0.00% <0.00%> (ø)
...libraries/matrix/impl/room/RoomContentForwarder.kt 0.00% <0.00%> (ø)
...droid/libraries/matrix/impl/room/RustMatrixRoom.kt 0.00% <0.00%> (ø)
...push/impl/notifications/NotifiableEventResolver.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty requested a review from ganfra September 27, 2023 08:48
@bmarty
Copy link
Member

bmarty commented Sep 27, 2023

@ganfra can you review my commits please? Thanks 🙏

@renovate
Copy link
Contributor Author

renovate bot commented Sep 27, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@bmarty bmarty force-pushed the renovate/org.matrix.rustcomponents-sdk-android-0.x branch from 1eb2840 to c9c7af6 Compare September 27, 2023 09:31
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A remark otherwise LGTM

}
}
}

private var inReplyToEventTimelineItem: EventTimelineItem? = null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should take the opportunity to create a SendService, so this doesn't pollute the MatrixRoom interface?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, MatrixRoom is starting to be a bit big... Later?

@bmarty bmarty enabled auto-merge September 27, 2023 09:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bmarty bmarty merged commit 971f8cf into develop Sep 27, 2023
@bmarty bmarty deleted the renovate/org.matrix.rustcomponents-sdk-android-0.x branch September 27, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants