Skip to content

RoomList : fix ANR (#1370) #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2023
Merged

RoomList : fix ANR (#1370) #1371

merged 1 commit into from
Sep 19, 2023

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 19, 2023

Fixes #1370

@ganfra ganfra marked this pull request as ready for review September 19, 2023 09:53
@ganfra ganfra requested a review from a team as a code owner September 19, 2023 09:53
@ganfra ganfra requested review from julioromano and removed request for a team September 19, 2023 09:53
@ganfra ganfra force-pushed the feature/fga/fix_anr branch 2 times, most recently from 7afa2d2 to a1ce60f Compare September 19, 2023 10:56
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/82p5Ph

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 54.54% and project coverage change: -0.01% ⚠️

Comparison is base (1eb9491) 57.81% compared to head (a1ce60f) 57.80%.
Report is 2 commits behind head on develop.

❗ Current head a1ce60f differs from pull request most recent head 6746bf5. Consider uploading reports for the commit 6746bf5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1371      +/-   ##
===========================================
- Coverage    57.81%   57.80%   -0.01%     
===========================================
  Files         1120     1120              
  Lines        29774    29773       -1     
  Branches      6114     6114              
===========================================
- Hits         17213    17210       -3     
- Misses        9876     9878       +2     
  Partials      2685     2685              
Files Changed Coverage Δ
...s/matrix/impl/roomlist/RoomSummaryListProcessor.kt 0.00% <0.00%> (ø)
...raries/matrix/impl/roomlist/RustRoomListService.kt 0.00% <0.00%> (ø)
...res/roomlist/impl/datasource/RoomListDataSource.kt 85.00% <100.00%> (-0.55%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@julioromano julioromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried a similar approach yesterday while reviewing #1330 though there's a problem:

  1. Open a room
  2. Go to room details
  3. Change its notification settings
  4. Go back to the room list

Notice how the room list hasn't updated and the room still shows the outdated notification settings icon.

@ganfra
Copy link
Member Author

ganfra commented Sep 19, 2023

Oh right, lets revert this part and only fix the anr then.
Anyway, it'll be handled by the rust sdk after, so will be better.

@ganfra ganfra force-pushed the feature/fga/fix_anr branch from a1ce60f to 2a434cb Compare September 19, 2023 12:00
@ganfra ganfra force-pushed the feature/fga/fix_anr branch from 2a434cb to 6746bf5 Compare September 19, 2023 12:01
@ganfra ganfra enabled auto-merge September 19, 2023 12:02
@ganfra ganfra merged commit f1ad735 into develop Sep 19, 2023
@ganfra ganfra deleted the feature/fga/fix_anr branch September 19, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ANR on RoomList
2 participants