-
Notifications
You must be signed in to change notification settings - Fork 232
RoomList : fix ANR (#1370) #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7afa2d2
to
a1ce60f
Compare
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1371 +/- ##
===========================================
- Coverage 57.81% 57.80% -0.01%
===========================================
Files 1120 1120
Lines 29774 29773 -1
Branches 6114 6114
===========================================
- Hits 17213 17210 -3
- Misses 9876 9878 +2
Partials 2685 2685
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried a similar approach yesterday while reviewing #1330 though there's a problem:
- Open a room
- Go to room details
- Change its notification settings
- Go back to the room list
Notice how the room list hasn't updated and the room still shows the outdated notification settings icon.
Oh right, lets revert this part and only fix the anr then. |
a1ce60f
to
2a434cb
Compare
2a434cb
to
6746bf5
Compare
Fixes #1370